----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54825/#review159538 -----------------------------------------------------------
Patch looks great! Reviews applied: [54825] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Dec. 16, 2016, 11:11 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54825/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2016, 11:11 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > process::Loop is a std::enable_shared_from_this. Using stack-allocated > instances of classes derived from std::enable_shared_from_this is > undefined behavior. > > Prevent creation of stack-allocated process::Loop instances by hiding > the constructors and providing a factory method to be used instead. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/loop.hpp > b35f7e6cc2da9d1c840656f80410756ba80dbc48 > > Diff: https://reviews.apache.org/r/54825/diff/ > > > Testing > ------- > > Observed only known test failures with: > > * `make check` (OS X, clang-trunk, w/optimizations, SSL) > * `make check` and `ROOT` tests on various Linux configurations in internal CI > > > Thanks, > > Benjamin Bannier > >
