----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54018/#review159230 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/tests/linkedhashmap_tests.cpp (line 167) <https://reviews.apache.org/r/54018/#comment230173> Why do we perform just a loose test here? - Michael Park On Nov. 23, 2016, 7:52 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54018/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 7:52 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6626 > https://issues.apache.org/jira/browse/MESOS-6626 > > > Repository: mesos > > > Description > ------- > > This requires providing `begin` and `end` member functions that return > iterators in insertion order. With the new implementation of > LinkedHashMap, this is easy to do. > > > Diffs > ----- > > 3rdparty/stout/include/stout/linkedhashmap.hpp > f48cc5933f9a786be325f71c83151376d1ffe844 > 3rdparty/stout/tests/linkedhashmap_tests.cpp > 376462d1b472586f1547512e6e0a1646c4f76a44 > > Diff: https://reviews.apache.org/r/54018/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
