----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54535/#review158794 -----------------------------------------------------------
Looks good, just some comment nits, and a recommendation to move the rename into a separate patch. include/mesos/authorizer/acls.proto (line 356) <https://reviews.apache.org/r/54535/#comment229599> s/nested// s/containers/container/ include/mesos/authorizer/acls.proto (line 360) <https://reviews.apache.org/r/54535/#comment229600> s/change/to change/ src/authorizer/local/authorizer.cpp (line 544) <https://reviews.apache.org/r/54535/#comment229601> Although I like the rename, it isn't really necessary for this patch, right? Maybe split it out into a followup patch. src/authorizer/local/authorizer.cpp (line 559) <https://reviews.apache.org/r/54535/#comment229602> s/and/`AND`/ src/tests/authorization_tests.cpp (line 1929) <https://reviews.apache.org/r/54535/#comment229603> s/frameworks/containers/ here and elsewhere - Adam B On Dec. 9, 2016, 7:32 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54535/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 7:32 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-6670 > https://issues.apache.org/jira/browse/MESOS-6670 > > > Repository: mesos > > > Description > ------- > > Adds the authorization action VIEW_CONTAINERS which takes an object > of type `FrameworkInfo` and `ExecutorInfo` and optionally a > `CommandInfo`. > > It also adds the authorization action SET_LOG_LEVEL which takes no > object. > > Includes testing for the ACLs and interface. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > 3499cac43d77c371448a9c9e1ac95d42b24a54dd > include/mesos/authorizer/authorizer.proto > b7371cd580bbe64eb1566876d0f253eedbd0789d > src/authorizer/local/authorizer.cpp > 3b983d0c0dea3ad761e7c684a9f943809dc541e9 > src/tests/authorization_tests.cpp f70d60d73a64e7eb4be20a17b62a8726b659e1b8 > > Diff: https://reviews.apache.org/r/54535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
