----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54524/#review158669 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/master/master.hpp (line 2681) <https://reviews.apache.org/r/54524/#comment229472> How about rename this as `roleMatched`? - Guangya Liu On 十二月 9, 2016, 9:39 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54524/ > ----------------------------------------------------------- > > (Updated 十二月 9, 2016, 9:39 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. > > > Bugs: MESOS-6685 > https://issues.apache.org/jira/browse/MESOS-6685 > > > Repository: mesos > > > Description > ------- > > Currently `resources()` method in `struct Role` of master.hpp returns > totalUsedResources and totalOfferedResources for a framework, which is > inaccurate for multi-role frameworks. A filter is added to capture the > actual resources for specific role in multi-role frameworks. > > > Diffs > ----- > > src/master/master.hpp d3c20d7cbb9137d3b05cae3d67f004d5e7475c8a > src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d > > Diff: https://reviews.apache.org/r/54524/diff/ > > > Testing > ------- > > make check on Ubuntu 14.04 > > > Thanks, > > Jay Guo > >
