----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158623 -----------------------------------------------------------
3rdparty/stout/include/stout/windows/os.hpp (line 753) <https://reviews.apache.org/r/54335/#comment229415> We aren't as worried about RAII in stout. So we can leave this TODO out. 3rdparty/stout/include/stout/windows/os.hpp (lines 755 - 757) <https://reviews.apache.org/r/54335/#comment229417> Suggestion: // Retrieves the directory of `ProgramData` for the // using default retrieval options, for the current user. // NOTE: The location of `ProgramData` is fixed and does // not depend on the current user. 3rdparty/stout/include/stout/windows/os.hpp (line 768) <https://reviews.apache.org/r/54335/#comment229414> Typo: "...Folderath" - Joseph Wu On Dec. 8, 2016, 12:22 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54335/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 12:22 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-6677 and MESOS-6722 > https://issues.apache.org/jira/browse/MESOS-6677 > https://issues.apache.org/jira/browse/MESOS-6722 > > > Repository: mesos > > > Description > ------- > > Returns `/var` on POSIX and (usually) `C:\ProgramData` on Windows. Uses > Windows > COM API to look up correct location for persistent, app-local (but not per > user) > variable data. Returns standard location on POSIX. > > The addition of `os::var()` is a continuation of the fix in #54336. The > correct > place for variable runtime data on Windows is not necessarily in > `os::temp()`, but > in the analogous location `ProgramData`. Thus we need a platform-agnostic way > to > refer to var. > > The call to `ShGetKnownFolder` is not RAII because it is a C API, and the ATL > `CComHeapPtr` class is not used in this commit due to Windows header issues. > Thus > the buffer allocated by the C API is freed immediately after the data is > copied > into a `std::wstring`. Because the Windows API returns a UTF-16 string, and > Unicode characters are valid in Windows path names, we have to correctly > convert > it to UTF-8 using `<codecvt>`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/os.hpp > 8443aa0cf0a8d8d52e36282611c2ab15ca4dd354 > 3rdparty/stout/include/stout/windows.hpp > d89c70902cf60544441608c2cb290b0727cbb45c > 3rdparty/stout/include/stout/windows/os.hpp > 2f20ccc64e255a60a1b7f33d684969942f12e45f > > Diff: https://reviews.apache.org/r/54335/diff/ > > > Testing > ------- > > make && make check on Linux: no failures. > msbuild and attach to a master on Windows: no failures. > > > Thanks, > > Andrew Schwartzmeyer > >
