-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54515/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 8:14 p.m.)
Review request for mesos and Alex Clemmer.
Changes
-------
Put updated description back.
Bugs: MESOS-6722
https://issues.apache.org/jira/browse/MESOS-6722
Repository: mesos
Description (updated)
-------
Instead of the absolute path `/var/run/mesos`, `os::runtime_dir()` returns a
platform-specific and permissions checked path for runtime data.
This updates the `Flags::runtime_dir` to simply default to `os::runtime_dir()`
instead of having platform-specific code in the CLI, thus fully resolving
MESOS-6722. The POSIX implementation of `os::runtime_dir()` also resolves the
comparison of `user == "root"` as a permission check by correctly checking the
permissions using `os::access`.
This updates the `Flags::docker_volume_checkpoint_dir` to use
`path::join(os::var(), ...)` instead of a hardcoded `/var/run/mesos` path.
Diffs
-----
src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3
Diff: https://reviews.apache.org/r/54515/diff/
Testing
-------
make && make check on Linux: no failures.
msbuild and attach to a master on Windows: no failures.
Checked that running agent as non-root on Linux *without* read/write
permissions to `/var/run`
correctly fell back to `/tmp/mesos/runtime`.
Checked that running as `root` on Linux and `Administrator` on Windows
chose the correct default `runtime_dir` paths.
Thanks,
Andrew Schwartzmeyer
