----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/#review158173 -----------------------------------------------------------
One minor comment is we *must* to commit this one together with https://reviews.apache.org/r/54360 , otherwise, the test `FrameworkInfoValidationTest.AcceptMultiRoleFramework` will be failed when `removeFramework` by `teardown`. - Guangya Liu On 十二月 6, 2016, 1:48 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54362/ > ----------------------------------------------------------- > > (Updated 十二月 6, 2016, 1:48 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-6684 > https://issues.apache.org/jira/browse/MESOS-6684 > > > Repository: mesos > > > Description > ------- > > When a multi-role framework is torn down, it should be removed from > internal data structure for every role in this framework. > > > Diffs > ----- > > src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 > > Diff: https://reviews.apache.org/r/54362/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
