> On Dec. 6, 2016, 12:21 p.m., Alexander Rukletsov wrote: > > docs/posix_rlimits.md, line 38 > > <https://reviews.apache.org/r/54414/diff/1/?file=1577617#file1577617line38> > > > > I think we should use indentation for non-c++ blobs. > > https://github.com/apache/mesos/blob/master/docs/markdown-style-guide.md
If you are referring to https://github.com/apache/mesos/blob/master/docs/markdown-style-guide.md#code-examples, note that we are not dealing with Doxygen's markdown parser here. The benefit of using fenced code blocks is that they allow us to specify a lexer, even though our current formatter does not always take advantage of it. > On Dec. 6, 2016, 12:21 p.m., Alexander Rukletsov wrote: > > docs/posix_rlimits.md, line 10 > > <https://reviews.apache.org/r/54414/diff/1/?file=1577617#file1577617line10> > > > > I'm not sure we do that. No, we shouldn't. Fixed. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54414/#review158145 ----------------------------------------------------------- On Dec. 6, 2016, 1:06 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54414/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 1:06 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-6427 > https://issues.apache.org/jira/browse/MESOS-6427 > > > Repository: mesos > > > Description > ------- > > * added front matter, > * add section headers, > * remove stray double spaces, > * used canonical delimiter for guarded code blocks, and > * used HTML table to enable canonical styling, see also MESOS-6729. > > > Diffs > ----- > > docs/posix_rlimits.md 0a0e6a8d20eb87852e0ce635b2de2caed94b7020 > > Diff: https://reviews.apache.org/r/54414/diff/ > > > Testing > ------- > > Checked with bundled site setup. > > > Thanks, > > Benjamin Bannier > >
