----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53982/#review158135 -----------------------------------------------------------
docs/posix_rlimits.md (lines 1 - 2) <https://reviews.apache.org/r/53982/#comment228879> Please add a standard header: ``` --- title: Apache Mesos - <title> layout: documentation --- ``` docs/posix_rlimits.md (lines 7 - 11) <https://reviews.apache.org/r/53982/#comment228880> Please be consistent inside a single doc: use either single space or double space. (I prefer single.) docs/posix_rlimits.md (lines 11 - 13) <https://reviews.apache.org/r/53982/#comment228883> How about adding some sections? It is usually easier for a reader to consume a write-up when it is split into chunks. Here the section caption could be "Specifying Resource Limits for a Task". docs/posix_rlimits.md (line 26) <https://reviews.apache.org/r/53982/#comment228881> Have you rendered it in the website container? I'm not sure `json` is supported now, see https://mesos.apache.org/documentation/latest/markdown-style-guide/ Also note that we use triple tilde instead of triple backtick. docs/posix_rlimits.md (lines 57 - 59) <https://reviews.apache.org/r/53982/#comment228884> A section here? For example, "Supported Resource Limits". docs/posix_rlimits.md (lines 64 - 65) <https://reviews.apache.org/r/53982/#comment228882> Even though I like this way of defining tables, it seems to be unsupported: https://mesos.apache.org/documentation/latest/markdown-style-guide/ You may check with Jörg what the limitations are and maybe even add support for markdown tables. That would be great! docs/posix_rlimits.md (lines 87 - 88) <https://reviews.apache.org/r/53982/#comment228885> It feels like this sentence suits better in the previous chapter about how to set rlimits in Mesos. - Alexander Rukletsov On Dec. 5, 2016, 10:14 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53982/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 10:14 a.m.) > > > Review request for mesos, Jie Yu and Neil Conway. > > > Bugs: MESOS-6427 > https://issues.apache.org/jira/browse/MESOS-6427 > > > Repository: mesos > > > Description > ------- > > Added documentation for posix/rlimit isolator. > > > Diffs > ----- > > docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 > docs/posix_rlimits.md PRE-CREATION > > Diff: https://reviews.apache.org/r/53982/diff/ > > > Testing > ------- > > Tested with github markdown renderer, and with build setup from `site/`. > > > Thanks, > > Benjamin Bannier > >
