> On Dec. 5, 2016, 2:10 a.m., Kevin Klues wrote: > > src/tests/containerizer/io_switchboard_tests.cpp, lines 308-309 > > <https://reviews.apache.org/r/54294/diff/2/?file=1576052#file1576052line308> > > > > Why not put this at the top with the other declaration for > > `IOSwitchboardServerTest`?
We typically put fixture close to its tests. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54294/#review157939 ----------------------------------------------------------- On Dec. 5, 2016, 12:17 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54294/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 12:17 a.m.) > > > Review request for mesos, Benjamin Hindman and Kevin Klues. > > > Bugs: MESOS-6470 > https://issues.apache.org/jira/browse/MESOS-6470 > > > Repository: mesos > > > Description > ------- > > Added an I/O switchboard test with TTY enabled. > > > Diffs > ----- > > src/tests/containerizer/io_switchboard_tests.cpp > d82f22b5c9a8d177577db3aeaae9e571e7e2fb80 > > Diff: https://reviews.apache.org/r/54294/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
