----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54328/ -----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Alex Clemmer. Repository: mesos Description ------- Connecting to the ANY address (0.0.0.0) is legal in BSD sockets, but results in an ambiguous connection. The outgoing connection could literally be anywhere on the network. These tests aim to connect to a specific socket on the local machine, and as such, should supply a valid IP address. This commit coincidentally fixes these tests on Windows, which disallows connecting to invalid IP addresses. Diffs ----- 3rdparty/libprocess/src/tests/http_tests.cpp 7f5425742d554b78fd4788c4a453068a604e1f46 Diff: https://reviews.apache.org/r/54328/diff/ Testing ------- CMake: make process_tests 3rdparty/libprocess/src/tests/process_tests --gtest_filter="HttpServeTest*" msbuild Mesos.sln /p:PreferredToolArchitecture=x64 /m /t:process_tests 3rdparty\libprocess\src\tests\Debug\process_tests.exe --gtest_filter="HttpServeTest.*" Thanks, Joseph Wu
