----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54296/#review157774 -----------------------------------------------------------
Fix it, then Ship it! LGTM, I would fix the minor nit before committing. src/slave/containerizer/mesos/io/switchboard.cpp (lines 788 - 795) <https://reviews.apache.org/r/54296/#comment228385> Nit: Reduce jaggedness ```cpp Owned<recordio::Reader<agent::Call>> reader( new recordio::Reader<agent::Call>( ::recordio::Decoder<agent::Call>(lambda::bind( deserialize<agent::Call>, contentType, lambda::_1)), request.reader.get())); ``` - Anand Mazumdar On Dec. 2, 2016, 6:48 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54296/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 6:48 a.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-6467 > https://issues.apache.org/jira/browse/MESOS-6467 > > > Repository: mesos > > > Description > ------- > > Updated the IOSwitchboard http handler to work with streaming requests. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 594c37e531c5b26599989a126aede56954d460fa > > Diff: https://reviews.apache.org/r/54296/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kevin Klues > >
