----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54302/#review157748 -----------------------------------------------------------
Fix it, then Ship it! The `Testing Done` section needs some update as previous comments in this patch chain. src/tests/master_validation_tests.cpp (lines 2485 - 2486) <https://reviews.apache.org/r/54302/#comment228368> new line here - Guangya Liu On 十二月 2, 2016, 8:51 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54302/ > ----------------------------------------------------------- > > (Updated 十二月 2, 2016, 8:51 a.m.) > > > Review request for mesos, Benjamin Mahler and Guangya Liu. > > > Bugs: MESOS-6629 > https://issues.apache.org/jira/browse/MESOS-6629 > > > Repository: mesos > > > Description > ------- > > Frameworks should fail on subscription with invalid settings of > 'roles'. Otherwise master should accept subscription. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > 5c44967a077551944831383a6bcc6dcb1c626df9 > > Diff: https://reviews.apache.org/r/54302/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
