> On Nov. 28, 2016, 6:46 p.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 17 > > <https://reviews.apache.org/r/53963/diff/1/?file=1568208#file1568208line17> > > > > Super tiny nit: we usually include these in the > > `ProcessTestsConfigure.cmake` to miniimize the number of things we have to > > include in order to configure a given tests package. I don't consider this > > a ship-stopper though.
Upon going further down the chain, I see that we're retiring the inclusion of `ProcessTestsConfigure` in all the other `CMakeLists.txt`. So we can likely mark this issue as "dropped". - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53963/#review157087 ----------------------------------------------------------- On Nov. 21, 2016, 10:08 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53963/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2016, 10:08 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Uses test variables defined in `StoutTestsConfigure` instead of > redefining the variables in the Mesos tests. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d > src/master/cmake/MasterConfigure.cmake > 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 > src/slave/cmake/SlaveConfigure.cmake > b339239761a5de321d65b92376dae69c339bee5c > src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 > src/tests/cmake/MesosTestsConfigure.cmake > 3f543c010ae87ff04e6b45745bc49ef65b6590ff > > Diff: https://reviews.apache.org/r/53963/diff/ > > > Testing > ------- > > cmake .. > > > Thanks, > > Joseph Wu > >
