> On Nov. 28, 2016, 2:32 a.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/io.hpp, line 130 > > <https://reviews.apache.org/r/54053/diff/1/?file=1569739#file1569739line130> > > > > We typically prefer explicit typing, instead of using typedef.
Meaning, don't have a type called `RedirectHook` at all and just use `vector<lambda::function<void(const std::string&)>> hooks` as the new parameter? I just thought it would be more readable with a typedef, and saw a bunch of ther typedefs for lambdas like this throughout the codebase. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54053/#review156982 ----------------------------------------------------------- On Nov. 24, 2016, 6:55 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54053/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2016, 6:55 a.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Bugs: MESOS-6639 > https://issues.apache.org/jira/browse/MESOS-6639 > > > Repository: mesos > > > Description > ------- > > These callback hooks will be invoked before passing any data read from > the 'from' file descriptor on to the 'to' file descriptor. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/io.hpp > eec5efd7e6b71a783f2bb40826054d0488cee71f > 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae > 3rdparty/libprocess/src/tests/io_tests.cpp > 66b610e35fa9f6a1738c77d181d76dca3921e6fb > > Diff: https://reviews.apache.org/r/54053/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j40 check > GTEST_FILTER="IOTest.Redirect" 3rdparty/libprocess/libprocess-tests > > > Thanks, > > Kevin Klues > >
