----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156963 -----------------------------------------------------------
src/master/validation.cpp (line 258) <https://reviews.apache.org/r/54062/#comment227342> s/FrameworkInfo.role/'FrameworkInfo.role' src/master/validation.cpp (line 259) <https://reviews.apache.org/r/54062/#comment227343> How about s/provided/enabled ? src/tests/master_validation_tests.cpp (line 2333) <https://reviews.apache.org/r/54062/#comment227346> s/validateRoles/`validateRoles` src/tests/master_validation_tests.cpp (line 2346) <https://reviews.apache.org/r/54062/#comment227345> How about use s/provided/enabled for here and following. src/tests/master_validation_tests.cpp (line 2416) <https://reviews.apache.org/r/54062/#comment227344> s/multiple role/multi-role I saw that the design document is using `multi-role framework`, so it is better keep consistent. Also you've already using `multi-role framework` in #2446 - Guangya Liu On 十一月 25, 2016, 3:40 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54062/ > ----------------------------------------------------------- > > (Updated 十一月 25, 2016, 3:40 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qiang Zhang. > > > Bugs: MESOS-6629 > https://issues.apache.org/jira/browse/MESOS-6629 > > > Repository: mesos > > > Description > ------- > > We need to do necessary validation for the conflicts of role, roles > and MULTI_ROLE capability. It complies with following matrix: > > -- MULTI_ROLE is NOT set - > |-------|---------| > |Roles |No Roles | > |-------|-------|---------| > |Role | Error | None | > |-------|-------|---------| > |No Role| Error | None | > |-------|-------|---------| > > --- MULTI_ROLE is set ---- > |-------|---------| > |Roles |No Roles | > |-------|-------|---------| > |Role | Error | Error | > |-------|-------|---------| > |No Role| None | None | > |-------|-------|---------| > > One test case is added to ensure validateRoles() catches invalid > combination of these attributes. Another three test cases are added > to ensure the master accepts/rejects subscription given valid/invalid > multiple roles. > > > Diffs > ----- > > src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a > src/master/validation.hpp b8389460f34b3531f2b6ff93f18f496c01e1a079 > src/master/validation.cpp 42d9b4a8784c2a161b74d7b46619cc22272e14e3 > src/tests/master_validation_tests.cpp > f893067859425967654401f3226149268b51cf57 > > Diff: https://reviews.apache.org/r/54062/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
