----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54061/#review156879 -----------------------------------------------------------
Can you update the summary as `Augmented FrameworkInfo to support multiple roles.`? As you are not only adding repeated roles but also a framework capability. - Guangya Liu On 十一月 24, 2016, 3:29 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54061/ > ----------------------------------------------------------- > > (Updated 十一月 24, 2016, 3:29 p.m.) > > > Review request for mesos and Guangya Liu. > > > Bugs: MESOS-6628 > https://issues.apache.org/jira/browse/MESOS-6628 > > > Repository: mesos > > > Description > ------- > > This is the initial patch to introduce multi-role frameworks. > A new section `repeated string roles` is added to FrameworkInfo. > Old `optional string role` is kept for backwards compatability. > To distinguish single-role and multi-role frameworks, a new framework > capability `MULTI_ROLE` is introduced. See MESOS-6628 for more info. > > > Diffs > ----- > > include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca > include/mesos/v1/mesos.proto 5b542ff9cd0b5f301c088d3f4b2fe17ae760d368 > > Diff: https://reviews.apache.org/r/54061/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
