----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54021/#review156705 -----------------------------------------------------------
Fix it, then Ship it! Looks good, just fix the comment. src/tests/containerizer/docker_containerizer_tests.cpp (line 552) <https://reviews.apache.org/r/54021/#comment226957> Not quite a sentence. Perhaps "Verify the ContainerStatus fields in the TaskStatus." - Adam B On Nov. 22, 2016, 10:06 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54021/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 10:06 p.m.) > > > Review request for mesos, Adam B, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6625 > https://issues.apache.org/jira/browse/MESOS-6625 > > > Repository: mesos > > > Description > ------- > > The test is updated to check for ContainerID in ContainerStatus. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16 > > Diff: https://reviews.apache.org/r/54021/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
