> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 188 > > <https://reviews.apache.org/r/52866/diff/1/?file=1537871#file1537871line188> > > > > Isn't this going to lead to some slightly confusing logging where we > > say "Rescheduling" for the first health check? > > Alexander Rukletsov wrote: > ``` > I1111 15:07:43.066488 1601536 health_checker.cpp:193] Health check > starting in 0ns, grace period 0ns > I1111 15:07:43.066573 1601536 health_checker.cpp:618] Rescheduling health > check in 0ns > W1111 15:07:43.158612 3747840 health_checker.cpp:215] Health check failed > 1 times consecutively: COMMAND health check failed: Command returned exited > with status 1 > I1111 15:07:43.158704 3747840 health_checker.cpp:618] Rescheduling health > check in 0ns > ``` > I don't think it is very confusing, but if you have a strong opinion, > I'll change that. > > Benjamin Mahler wrote: > Could we ensure (separately from this change) that we log the entire > health check config when using vlog level 1? > > Seems like it would be an easy improvement to go from > s/Rescheduling/Scheduling/ for every instance of this log line?
Posted https://reviews.apache.org/r/54007/ - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review153584 ----------------------------------------------------------- On Nov. 23, 2016, 12:30 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52866/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 12:30 a.m.) > > > Review request for mesos, Gastón Kleiman and haosdent huang. > > > Repository: mesos > > > Description > ------- > > To facilitate code reuse, HealthChecker::reschedule() is generalized. > This will become even more valuable when we add pause/resume functions. > > > Diffs > ----- > > src/health-check/health_checker.hpp > 837d1358e418d21536da488e4a23cbfa41db6060 > src/health-check/health_checker.cpp > af5500be249c74a4a5e64bf38dea607173e2f998 > > Diff: https://reviews.apache.org/r/52866/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
