----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/#review156377 -----------------------------------------------------------
After discussion offline, there seems to be some interesting questions around pause/resume functionality: (1) What are the implications for timeouts, delays, etc? (e.g. do we reset the consecutive failure counters? do we schedule a new health check immediately or wait for another delay?) (2) Since we only need to support the ability to stop health checking for now, maybe we can just avoid having to consider these questions and only supporting stop for now. - Benjamin Mahler On Nov. 14, 2016, 10:29 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52868/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 10:29 a.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang. > > > Bugs: MESOS-5963 > https://issues.apache.org/jira/browse/MESOS-5963 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/health-check/health_checker.hpp > a1dc72493ff31b87068d5691f4d5b794392caf76 > src/health-check/health_checker.cpp > e2b32e2d57515202f547d12ba492ad8eb633641b > > Diff: https://reviews.apache.org/r/52868/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
