----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/#review156294 -----------------------------------------------------------
src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp (line 38) <https://reviews.apache.org/r/53837/#comment226513> shouldn't this include be the first one in the file? src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp (line 149) <https://reviews.apache.org/r/53837/#comment226514> s/spawened/spawned/ src/slave/containerizer/mesos/io_switchboard/main.cpp (line 31) <https://reviews.apache.org/r/53837/#comment226515> Move this include to the top. src/slave/containerizer/mesos/io_switchboard/main.cpp (line 66) <https://reviews.apache.org/r/53837/#comment226518> This struct is instantiated in line 80. Do we consider such a struct an `abstract class`? src/slave/containerizer/mesos/io_switchboard/main.cpp (line 243) <https://reviews.apache.org/r/53837/#comment226516> I know that this is an internal binary, but we might want to print the usage and exit with a failure if `--help` is passed: ``` if (flags.help) { EXIT(EXIT_FAILURE) << flags.usage(); } ``` - Gastón Kleiman On Nov. 18, 2016, 5:07 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53837/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 5:07 a.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6467 > https://issues.apache.org/jira/browse/MESOS-6467 > > > Repository: mesos > > > Description > ------- > > Currently, this process simply intercepts the stdout/stderr of a > container and writes it to the stdout/stderr FDs set up by the > container logger. In future commits, this process will be expanded to > allow dynamically attaching new input / output sources to a container > to support `docker attach` like functionality for a running container. > > > Diffs > ----- > > src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac > src/slave/containerizer/mesos/containerizer.cpp > ec4ae32485a7ab6c9f73c512004d1220482a188e > src/slave/containerizer/mesos/io_switchboard/io_switchboard.hpp > PRE-CREATION > src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp > PRE-CREATION > src/slave/containerizer/mesos/io_switchboard/main.hpp PRE-CREATION > src/slave/containerizer/mesos/io_switchboard/main.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53837/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j check > sudo src/mesos-tests > > > Thanks, > > Kevin Klues > >
