----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/#review155915 -----------------------------------------------------------
src/tests/container_logger_tests.cpp (line 782) <https://reviews.apache.org/r/53699/#comment226006> Should I remove the below function? - Sivaram Kannan On Nov. 14, 2016, 9:51 p.m., Sivaram Kannan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53699/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 9:51 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > Add test cases to test logrotate with switch_user set to true and false. > > > Diffs > ----- > > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > > Diff: https://reviews.apache.org/r/53699/diff/ > > > Testing > ------- > > Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > Run the mesos-logrotate-logger as root user and verify whether the logs are > getting rotated. > > > Thanks, > > Sivaram Kannan > >
