> On 十一月 12, 2016, 12:14 p.m., Guangya Liu wrote: > > We do not have `external containerizer` now, so you can remove it from the > > `Descripiton`. > > > > Summary > > ``` > > Only check `gpu/nvidia` isolator for mesos containerizer. > > ``` > > > > Description > > ``` > > Mesos containerizer uses isolator `gpu/nvidia` for GPU isolation while > > docker containerizers do not need it. This patch is making the isolator > > `gpu/nvidia` check only available for mesos containerizer but not docker > > containerizer in GPU allocator. > > ```
fixed. thanks - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review155777 ----------------------------------------------------------- On 十一月 10, 2016, 8:13 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50947/ > ----------------------------------------------------------- > > (Updated 十一月 10, 2016, 8:13 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5975 > https://issues.apache.org/jira/browse/MESOS-5975 > > > Repository: mesos > > > Description > ------- > > Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while > docker and external containerizers do not need it anymore. This removed > the 'gpu/nvidia' isolator check for docker and external containerizers. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp > 2e722691475c84afae14009014ea70cc0fdd0e65 > > Diff: https://reviews.apache.org/r/50947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
