----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53691/#review155775 -----------------------------------------------------------
Patch looks great! Reviews applied: [52284, 53679, 53691] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 12, 2016, 7:59 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53691/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2016, 7:59 a.m.) > > > Review request for mesos, Alexander Rukletsov and Xiaojian Huang. > > > Bugs: MESOS-4292 > https://issues.apache.org/jira/browse/MESOS-4292 > > > Repository: mesos > > > Description > ------- > > This implements some tests in previous todos for > quota functionality. > > The one for: > > `Role quota is below its allocation (InverseOffer generation).` > > does not seem be implementable right now, since > hierarchical allocator does not send InverseOffer for > quota yet. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b > > Diff: https://reviews.apache.org/r/53691/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
