----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53682/#review155760 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Nov. 11, 2016, 11:21 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53682/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 11:21 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6464 > https://issues.apache.org/jira/browse/MESOS-6464 > > > Repository: mesos > > > Description > ------- > > For some isolators, this meant adding an explicit dependency on > 'filesystem/linux' and then removing any of their local calls to > 'set_clone_namespaces(CLONE_NEWNS)'. For others, this meant simply > removing their explicit 'set_clone_namespaces(CLONE_NEWNS)' calls > since they are redundant with the one made by 'filesystem/linux'. > > The 'cni' isolator is a special case, however, because it may need to > call 'set_clone_namespaces(CLONE_NEWNS)' even if the > 'filesystem/posix' isolator is enabled. For this we added a comment. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > e3756c920081f2944bf4b640edf0a83f42784586 > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > 0d9ec57d9aa83bcc6cc2e5a8d75f2e2251179b1b > src/slave/containerizer/mesos/isolators/volume/image.cpp > 210e67ad0d84f52135e77184f21e574c9e31628d > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > 7b976d29226c3e0a4d52922e9d2f7e685de72297 > > Diff: https://reviews.apache.org/r/53682/diff/ > > > Testing > ------- > > testing done at end of chain > > > Thanks, > > Kevin Klues > >
