----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/#review154850 -----------------------------------------------------------
src/tests/default_executor_tests.cpp (line 64) <https://reviews.apache.org/r/53266/#comment224603> Let's don't do this refactor here. I'd suggest we smartly generate `::testing::Values` based on if Docker is available or not. In other words, use "mesos" if docker is not avaialable and use "mesos", "docker,mesos" if it is. - Jie Yu On Oct. 31, 2016, 4:08 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53266/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 4:08 p.m.) > > > Review request for mesos, Till Toenshoff, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6455 > https://issues.apache.org/jira/browse/MESOS-6455 > > > Repository: mesos > > > Description > ------- > > This test is parameterized, making it run with both the Docker and the > Mesos containerizers. > > The test name doesn't contain `DOCKER_,` so the test instantiation that > uses the Docker containerizer will run and fail if Docker is not > available. > > Because the test name starts with `ROOT_`, it only runs if root tests > are not filtered, but root by the Mesos containerizer. > > I moved moved the body of the test into a fixture method, so that I > could split `ROOT_TaskRunning` into `TaskRunning` and > `ROOT_DOCKER_TaskRunning`. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 70779e8d94fbb6e664cad4ddbfeb19e560176cfe > > Diff: https://reviews.apache.org/r/53266/diff/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.* > --docker=/tmp/foo` > `sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.*` > > > Thanks, > > Gastón Kleiman > >
