----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review154524 -----------------------------------------------------------
configure.ac (line 485) <https://reviews.apache.org/r/52645/#comment224103> `s/!$/./` m4/ax_check_compile_flag.m4 (line 1) <https://reviews.apache.org/r/52645/#comment224102> For future updates it would be great if we'd write down the autoconf-archive release this file came from (it looks like the latest release containing it is `v2016.09.16`). src/Makefile.am (lines 102 - 110) <https://reviews.apache.org/r/52645/#comment224125> I think this would be easier to follow if you'd incrementially build up `AM_CXXFLAGS` while explaining their effect, e.g., # Enable common (and some language specific) warnings. AM_CXXFLAGS += -Wall # Warn when a comparison is made between signed and unsigned values. AM_CXXFLAGS += -Wsign-compare ... src/Makefile.am (line 114) <https://reviews.apache.org/r/52645/#comment224119> I am not a big fan of unconditionally omitting frame pointers as this gives the optimizer one less register to work with. Unfortunately one cannot easily tell the actual impact of this from the info here. Is this strictly needed here or just nice to have? src/Makefile.am <https://reviews.apache.org/r/52645/#comment224117> Not sure we want to remove the existing `-Werror`. - Benjamin Bannier On Nov. 1, 2016, 8:37 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52645/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 8:37 p.m.) > > > Review request for mesos, James Peach, Michael Park, and Neil Conway. > > > Bugs: MESOS-6229 > https://issues.apache.org/jira/browse/MESOS-6229 > > > Repository: mesos > > > Description > ------- > > Use a default set of flags to provide additional security and hardening to > Mesos. Additionally, check and catch more warnings/errors. > > > Diffs > ----- > > configure.ac c8d48be > m4/ax_check_compile_flag.m4 PRE-CREATION > src/Makefile.am c2f9e44 > > Diff: https://reviews.apache.org/r/52645/diff/ > > > Testing > ------- > > Compared the benchmarks with and without the flags being used. Also did a > comparsion with the flags being used with and without optimizations and > without the flags being used with and without optimizations. Overall the > performance hit was very small with a 3-8% overhead (optimizations brings > this down slightly). Most benchmarks were about 5% (or less) slower. > > > Thanks, > > Aaron Wood > >
