----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review154004 -----------------------------------------------------------
src/tests/health_check_tests.cpp (lines 357 - 361) <https://reviews.apache.org/r/52563/#comment223525> I don't see any reconciliation happening in this test. src/tests/health_check_tests.cpp (lines 475 - 479) <https://reviews.apache.org/r/52563/#comment223526> Neither here. src/tests/health_check_tests.cpp (lines 842 - 845) <https://reviews.apache.org/r/52563/#comment223527> I don't see endpoint verification. src/tests/health_check_tests.cpp (lines 1178 - 1180) <https://reviews.apache.org/r/52563/#comment223528> No need to wrap. - Alexander Rukletsov On Oct. 21, 2016, 11:13 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52563/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 11:13 a.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > * Replace `Testing` to `Tests` in comments. > * Remove redundant `.Times(1)`. > * Fix typos. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 > > Diff: https://reviews.apache.org/r/52563/diff/ > > > Testing > ------- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest.*" > --gtest_also_run_disabled_tests > [----------] Global test environment tear-down > [==========] 19 tests from 1 test case ran. (35264 ms total) > [ PASSED ] 19 tests. > ``` > > > Thanks, > > haosdent huang > >
