----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review153989 -----------------------------------------------------------
src/tests/health_check_tests.cpp (line 1388) <https://reviews.apache.org/r/52250/#comment223474> s/healthy task/healthy non-contained task src/tests/health_check_tests.cpp (line 1397) <https://reviews.apache.org/r/52250/#comment223473> You don't need this blank line. src/tests/health_check_tests.cpp (line 1417) <https://reviews.apache.org/r/52250/#comment223478> const src/tests/health_check_tests.cpp (line 1421) <https://reviews.apache.org/r/52250/#comment223479> const src/tests/health_check_tests.cpp (line 1442) <https://reviews.apache.org/r/52250/#comment223476> s/statusHealth/statusHealthy src/tests/health_check_tests.cpp (lines 1446 - 1447) <https://reviews.apache.org/r/52250/#comment223475> ` .WillRepeatedly(Return()); // Ignore subsequent updates.` src/tests/health_check_tests.cpp (lines 1463 - 1464) <https://reviews.apache.org/r/52250/#comment223485> Add the same sentence from the next test: // To emulate a task responsive to HTTP health checks, starts Netcat in the docker "alpine" image. src/tests/health_check_tests.cpp (line 1477) <https://reviews.apache.org/r/52250/#comment223477> kill this. src/tests/health_check_tests.cpp (line 1497) <https://reviews.apache.org/r/52250/#comment223480> const src/tests/health_check_tests.cpp (line 1500) <https://reviews.apache.org/r/52250/#comment223481> const src/tests/health_check_tests.cpp (line 1526) <https://reviews.apache.org/r/52250/#comment223482> s/statusHealth/statusHealthy src/tests/health_check_tests.cpp (lines 1530 - 1531) <https://reviews.apache.org/r/52250/#comment223483> ` .WillRepeatedly(Return()); // Ignore subsequent updates.` src/tests/health_check_tests.cpp (line 1594) <https://reviews.apache.org/r/52250/#comment223487> const src/tests/health_check_tests.cpp (line 1597) <https://reviews.apache.org/r/52250/#comment223488> const src/tests/health_check_tests.cpp (line 1608) <https://reviews.apache.org/r/52250/#comment223486> why not "library/alpine" like in the previous test? src/tests/health_check_tests.cpp (line 1632) <https://reviews.apache.org/r/52250/#comment223489> s/statusHealth/statusHealthy - Alexander Rukletsov On Oct. 21, 2016, 11:12 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52250/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 11:12 a.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Bugs: MESOS-6278 > https://issues.apache.org/jira/browse/MESOS-6278 > > > Repository: mesos > > > Description > ------- > > Added test cases for HTTP health check. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 > > Diff: https://reviews.apache.org/r/52250/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
