----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52947/#review153835 -----------------------------------------------------------
src/cli_new/bin/config.py (lines 63 - 72) <https://reviews.apache.org/r/52947/#comment223318> Hm, perhaps I'm missing some context, but shouldn't there be a `globals()[config_key_upper] = <something>` here? src/cli_new/lib/mesos/plugins/base.py (lines 102 - 108) <https://reviews.apache.org/r/52947/#comment223319> Formatting a template string with an empty dict seems like an odd thing to do. Instead, consider moving this code addition to https://reviews.apache.org/r/52951/ - Joseph Wu On Oct. 20, 2016, 11:12 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52947/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 11:12 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > ------- > > This includes the ability to inject the values from these config > parameters into plugin help strings. > > > Diffs > ----- > > src/cli_new/bin/config.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 > src/cli_new/lib/mesos/plugins/base.py > 61b15428b029cec9ec7c9d89ab949959c3dc5b88 > > Diff: https://reviews.apache.org/r/52947/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
