> On Oct. 21, 2016, 9:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 937 > > <https://reviews.apache.org/r/53035/diff/1/?file=1541816#file1541816line937> > > > > here "register" is used to mean register or re-register. just like #918. > > Neil Conway wrote: > Sure; but when it is easy to do so, I think it is an improvement to avoid > saying we're going to "attempt to register" when we actually aren't; > obviously there is a significant semantic difference between "registration" > and "re-registration" in Mesos.
I think if we want to be explicit about when the agent is registering vs re-registering we need to be consistent about it. It's more confusing if sometimes registering means both and sometimes not. One suggestion #918: LOG(INFO) << "Skipping (re-)registration because agent is terminating" #933: LOG(INF) << "Attempting to (re-)register without authentication because no credentials were provided" I want to make sure #933 lets the user know that agent is attempting registration, not the fact that there are no credentials provided/auth disabled. That information doesn't change over time. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53035/#review153600 ----------------------------------------------------------- On Oct. 24, 2016, 5:38 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53035/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 5:38 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The previous wording implied the agent was going to "attempt to > register"; in fact the agent might never attempt to "register" (only > re-register) depending on its local state. > > > Diffs > ----- > > src/slave/slave.cpp 881c10ac61d1e4fdeabdc42c0a41508c36f49040 > > Diff: https://reviews.apache.org/r/53035/diff/ > > > Testing > ------- > > Visual inspection of log output. > > > Thanks, > > Neil Conway > >
