----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/#review153643 -----------------------------------------------------------
According to our documentation we are still in the phase of deprecating the old environment variables - hence we should actually test for both variants, no? >From https://github.com/apache/mesos/blob/master/docs/ssl.md#Upgrading ``` To be backward compatible, we accept environment variables prefixed by both SSL_ or LIBPROCESS_SSL_. New users should use the LIBPROCESS_SSL_ version. ``` - Till Toenshoff On Oct. 21, 2016, 11:36 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53084/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 11:36 a.m.) > > > Review request for mesos, Alexander Rukletsov, haosdent huang, Jie Yu, Till > Toenshoff, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > According to the documentation it is `LIBPROCESS_SSL_ENABLED`, not > `SSL_ENABLED`. > > > Diffs > ----- > > src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 > src/scheduler/scheduler.cpp e282d419119dd1f01e170acf5cc2c6175b59791d > > Diff: https://reviews.apache.org/r/53084/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gastón Kleiman > >
