> On Oct. 21, 2016, 11:52 p.m., Benjamin Mahler wrote: > >
Also need two lines between top level functions in the cpp file. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52975/#review153616 ----------------------------------------------------------- On Oct. 21, 2016, 11:27 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52975/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 11:27 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Factored out the create port range logic to test resources_utils. > > > Diffs > ----- > > src/Makefile.am 05fe8fa3e3409b35ba66d7e7238e988fb0fab07d > src/tests/CMakeLists.txt f5d66dc63143455506d8660674fbd9eb227625ff > src/tests/hierarchical_allocator_tests.cpp > 2e979d784b8e6cdacebac78a67498b5f4d023540 > src/tests/resources_utils.hpp PRE-CREATION > src/tests/resources_utils.cpp PRE-CREATION > src/tests/sorter_tests.cpp 1f17c011898836ea9159661dde7d544cb0d8ea83 > > Diff: https://reviews.apache.org/r/52975/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="*HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0" > ./bin/mesos-tests.sh --benchmark > --gtest_filter="*Sorter_BENCHMARK_Test.FullSort/*" > ``` > > > Thanks, > > Guangya Liu > >
