----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52818/#review153489 -----------------------------------------------------------
Thanks for the cleanup. Can you also update the summary/description to mention that we are waiting for the agent recovery to be complete and not registration? src/tests/slave_authorization_tests.cpp (lines 398 - 401) <https://reviews.apache.org/r/52818/#comment222853> hmm, let's be consistent and do something like: https://github.com/apache/mesos/blob/master/src/tests/slave_tests.cpp#L1727 https://github.com/apache/mesos/blob/master/src/tests/executor_http_api_tests.cpp#L120 https://github.com/apache/mesos/blob/master/src/tests/api_tests.cpp#L2241 etc. This works here since we do not have any frameworks and the future would be fulfilled without waiting for the executors to re-register i.e., no `process::delay(...)` is invoked: https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5265 Not yours but we should fix the other instance in this file too since it seems to be an outlier. - Anand Mazumdar On Oct. 13, 2016, 9:08 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52818/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 9:08 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > Ensured agent is registered in SlaveEndpointTests. > > > Diffs > ----- > > src/tests/slave_authorization_tests.cpp > 6bd2aa96cb05aa087c0807cc3dd1830451efe106 > > Diff: https://reviews.apache.org/r/52818/diff/ > > > Testing > ------- > > `make check` (OS X, clang-3.9 w/o optimizations) > > > Thanks, > > Benjamin Bannier > >
