----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51495/#review153041 -----------------------------------------------------------
Looks good besides the wrapping 3rdparty/libprocess/src/tests/http_tests.cpp (lines 204 - 205) <https://reviews.apache.org/r/51495/#comment222305> We generally prefer to wrap (2-space indent) after the `=` whenever reasonable. Please fix here and everywhere in these patches. - Adam B On Aug. 29, 2016, 10:27 p.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51495/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2016, 10:27 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-4440 > https://issues.apache.org/jira/browse/MESOS-4440 > > > Repository: mesos > > > Description > ------- > > Replace http::get with http::request in libprocess project. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/benchmarks.cpp > 945007c38f96a66212f5ebdd700a117a4902a736 > 3rdparty/libprocess/src/tests/http_tests.cpp > 24b266df5f17e28e0c95326f5d1ea451952500e8 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 88526e67a20b7b58a6e14034215faa3ae9879fd0 > 3rdparty/libprocess/src/tests/process_tests.cpp > b9feec7e34cffe19e49035f8865b150f79258f54 > 3rdparty/libprocess/src/tests/profiler_tests.cpp > 995bd02f6ecce484cd9b2aca355c2707d73d40b2 > 3rdparty/libprocess/src/tests/system_tests.cpp > 0f4d0424689522337806ba2227ec4330c700e17e > > Diff: https://reviews.apache.org/r/51495/diff/ > > > Testing > ------- > > make & make check successfully! > > > Thanks, > > Yongqiao Wang > >
