----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152909 -----------------------------------------------------------
The length of the commit message greater than 72, I think it could not pass jenkins check. src/launcher/default_executor.cpp (line 1022) <https://reviews.apache.org/r/52879/#comment222095> Not sure if ``` The `ExecutorID` uses to send `SUBSCRIBE` call. ``` / ``` The id of the executor uses to send `SUBSCRIBE` call. ``` would be better. src/launcher/default_executor.cpp (line 1026) <https://reviews.apache.org/r/52879/#comment222096> Not sure if ``` The `FrameworkID` uses to send `SUBSCRIBE` call. ``` / ``` The id of the framework uses to send `SUBSCRIBE` call. ``` would be better. src/launcher/default_executor.cpp (line 1034) <https://reviews.apache.org/r/52879/#comment222094> Let's use `agent_pid` here? Since we rename slave to agent. src/launcher/default_executor.cpp (lines 1056 - 1059) <https://reviews.apache.org/r/52879/#comment222097> Usually we put `flags.help` before `load.isError()` (refer to `master/main.cpp`), otherwise when `--help` would see the load error message and get not 0 exit status. src/launcher/executor.cpp (lines 854 - 855) <https://reviews.apache.org/r/52879/#comment222098> If rephrase to ``` The directory's absolute path of Mesos binaries ``` would be better? - haosdent huang On Oct. 14, 2016, 5:17 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52879/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 5:17 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, Jie Yu, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Updated the command and the default executor so that they use only > `stout::flags` to load config options. > > They used to use a mix of `stout::flags` and `os::getenv`. > > > Diffs > ----- > > src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 > src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 > > Diff: https://reviews.apache.org/r/52879/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Gastón Kleiman > >
