----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152136 -----------------------------------------------------------
configure.ac (line 455) <https://reviews.apache.org/r/52645/#comment220912> Support `-fstack-protector-strong` when possible, otherwise use `-fstack-protector` and don't make 4.9 a requirement. src/Makefile.am <https://reviews.apache.org/r/52645/#comment220911> Removing this and putting it in AM_CXXFLAGS causes builds to fail, at least on OS X due to these warnings being treated as hard errors: ``` clang: warning: argument unused during compilation: '-pthread' clang: warning: argument unused during compilation: '-pie' ``` - Aaron Wood On Oct. 10, 2016, 7:50 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52645/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 7:50 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6229 > https://issues.apache.org/jira/browse/MESOS-6229 > > > Repository: mesos > > > Description > ------- > > Use a default set of flags to provide additional security and hardening to > Mesos. Additionally, check and catch more warnings/errors. > > > Diffs > ----- > > configure.ac 034bb91 > src/Makefile.am fd01e1d > > Diff: https://reviews.apache.org/r/52645/diff/ > > > Testing > ------- > > Compared the benchmarks with and without the flags being used. Also did a > comparsion with the flags being used with and without optimizations and > without the flags being used with and without optimizations. Overall the > performance hit was very small with a 3-8% overhead (optimizations brings > this down slightly). Most benchmarks were about 5% (or less) slower. > > > Thanks, > > Aaron Wood > >
