> On Oct. 7, 2016, 5:03 p.m., Jie Yu wrote: > > src/linux/fs.cpp, lines 141-143 > > <https://reviews.apache.org/r/52597/diff/1/?file=1524412#file1524412line141> > > > > Does this compile? > > Kevin Klues wrote: > Interestingly yes... > > Though I see why you think it shouldn't (I would think it shouldn't > either). My guess is that the `CHECK()` macro ends with a type that allows > adding a quoted string to concatenate to it, without the need for `<<`. > > Either way, do you want me to update it to: > > ``` > CHECK(!visitedParents.contains(parentId)) << > "Cycle found in mount table hierarchy at entry" > " '" << stringify(parentId) << "': " << std::endl << lines.get(); > ```
I've fixed this as part of a refactor in a subsequent commit. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52597/#review151817 ----------------------------------------------------------- On Oct. 6, 2016, 7:31 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52597/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 7:31 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6118 > https://issues.apache.org/jira/browse/MESOS-6118 > > > Repository: mesos > > > Description > ------- > > Added more detailed error message when failing in MountInfoTable::read. > > > Diffs > ----- > > src/linux/fs.cpp 4b10141a49dfb3c6defdb07e295eb14cfcdd36ce > > Diff: https://reviews.apache.org/r/52597/diff/ > > > Testing > ------- > > make > > > Thanks, > > Kevin Klues > >
