----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52569/#review151605 -----------------------------------------------------------
Fix it, then Ship it! src/slave/http.cpp (line 1954) <https://reviews.apache.org/r/52569/#comment220037> typo: executor src/slave/slave.hpp (line 916) <https://reviews.apache.org/r/52569/#comment220038> This and the corresponding changes in slave.cpp could've been done in a separate review? src/tests/api_tests.cpp (lines 3355 - 3369) <https://reviews.apache.org/r/52569/#comment220042> could have used the LaunchTask action? src/tests/api_tests.cpp (lines 3490 - 3512) <https://reviews.apache.org/r/52569/#comment220046> ditto. - Vinod Kone On Oct. 5, 2016, 8:45 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52569/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 8:45 p.m.) > > > Review request for mesos, Gilbert Song and Vinod Kone. > > > Bugs: MESOS-6289 > https://issues.apache.org/jira/browse/MESOS-6289 > > > Repository: mesos > > > Description > ------- > > This locates the executor that corresponds to the parent container, > and uses the user that was used to launch the executor. > > > Diffs > ----- > > src/slave/http.cpp bdafe1db9f1b22ac0761f5119e73f87b531c6a3c > src/slave/slave.hpp 9beefa12283e936684d82c97ebd3ac6506475edf > src/slave/slave.cpp fba089506850eec87f67a46694a1ef645cdf4ad5 > src/tests/api_tests.cpp 7b0ad3c18a38b5ec859a79d09f5707f6958960fb > > Diff: https://reviews.apache.org/r/52569/diff/ > > > Testing > ------- > > Now that the executor is looked up, the tests have been updated to > launch an executor and use it's container id as the parent. > > > Thanks, > > Benjamin Mahler > >
