> On Oct. 5, 2016, 5:20 p.m., Till Toenshoff wrote: > > configure.ac, line 1988 > > <https://reviews.apache.org/r/52162/diff/1/?file=1508085#file1508085line1988> > > > > Can we please add one additional comment here; something like: > > > > ``` > > # NOTE: Do not update any compiler or linker settings (e.g. CXXFLAGS, > > # LDFLAGS, ...) beyond this line. > > ``` > > > > Feel free to change the wording as I am not a native speaker :)
Done. I'm not a native speaker either so I used your wording :) - Ilya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52162/#review151509 ----------------------------------------------------------- On Oct. 5, 2016, 2:45 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52162/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 2:45 p.m.) > > > Review request for mesos, Benjamin Bannier, Kapil Arya, and Till Toenshoff. > > > Bugs: MESOS-6207 > https://issues.apache.org/jira/browse/MESOS-6207 > > > Repository: mesos > > > Description > ------- > > Moved Python related configuration steps down below all others. Now > PYTHON_LDFLAGS variable captures all required LDFLAGS. > > > Diffs > ----- > > configure.ac 57482d39db1f83e92e75fca959cd6df329a1c24f > > Diff: https://reviews.apache.org/r/52162/diff/ > > > Testing > ------- > > ``` > ../configure --with-svn=$HOME/svn && make && make check > ``` > > > Thanks, > > Ilya Pronin > >
