----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52480/#review151190 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/paths.cpp (lines 186 - 193) <https://reviews.apache.org/r/52480/#comment219467> Suggestion: "It is possible that the 'backends' directory does not exist for a container ID that is present in the checkpoint directory because we allow the case where a nested container specifies a container image while its parent container does not. In this case, no image is provisioned for the parent container and the 'backends' directory does not exist, so we can skip recovering the parent container's `Info` in the provisioner." - Greg Mann On Oct. 3, 2016, 6:21 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52480/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 6:21 a.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Jie Yu, Timothy Chen, > and Vinod Kone. > > > Bugs: MESOS-6302 > https://issues.apache.org/jira/browse/MESOS-6302 > > > Repository: mesos > > > Description > ------- > > Previously, in provisioner recover, we firstly get all container > ids from the provisioner directory, and then find all rootfses > from each container's 'backends' directory. We made an assumption > that if a 'container_id' directory exists in the provisioner > directory, it must contain a 'backends' directory underneath, > which contains at least one rootfs for this container. > > However, this is no longer true since we added support for nested > containers. Because we allow the case that a nested container is > specified with a container image while its parent does not have > an image specified. In this case, when the provisioner recovers, > it can still find the parent container's id in the provisioner > directory while no 'backends' directory exists, since all nested > containers backend information are under its parent container's > directory. > > As a result, we should skip recovering the 'Info' struct in > provisioner for the parent container if it never provisions any > image. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/paths.cpp > d9f87e3c82140d25d42d89566def8bac1dc6385a > > Diff: https://reviews.apache.org/r/52480/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
