----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/#review151016 -----------------------------------------------------------
Patch looks great! Reviews applied: [52412] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 30, 2016, 5:19 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52412/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 5:19 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-6290 > https://issues.apache.org/jira/browse/MESOS-6290 > > > Repository: mesos > > > Description > ------- > > Currently, there are two issues in mesos containerizer using logger > for nested contaienrs: > 1. An empty executorinfo is passed to logger when launching a nested > container, it would potentially break some logger modules if any > module tries to access the required proto field (e.g., executorId). > 2. The logger does not reocver the nested containers yet in > MesosContainerizer::recover. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 522d2c37229b07b66a0824c3e246c32f8d803b10 > > Diff: https://reviews.apache.org/r/52412/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
