----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/#review150411 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/default_executor.cpp (line 380) <https://reviews.apache.org/r/52148/#comment218384> These should be `LOG()` statements. See my comments in the earlier review. src/launcher/default_executor.cpp (line 389) <https://reviews.apache.org/r/52148/#comment218385> sorry, missed it earlier; why should shutdown be ignored if no task group is launched? looks this should just call `__shutdown()` after setting `shuttingDown = true`? src/launcher/default_executor.cpp (line 424) <https://reviews.apache.org/r/52148/#comment218387> // NOTE: We capture `connection` ... That said I don't follow why `connection` will get disconnected if we don't capture it? Do you mean because it goes out of scope? AFAICT, it is used by `kill` calls which makes post requests. src/launcher/default_executor.cpp (line 448) <https://reviews.apache.org/r/52148/#comment218388> s/Committing suicide/Terminating after/ src/launcher/default_executor.cpp (line 479) <https://reviews.apache.org/r/52148/#comment218390> LOG(WARNING). Remember that this is an executor implementation and not a library. So you can be generous with using `LOG`. - Vinod Kone On Sept. 25, 2016, 10:05 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52148/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2016, 10:05 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6227 > https://issues.apache.org/jira/browse/MESOS-6227 > > > Repository: mesos > > > Description > ------- > > This change implements support for killing child containers via > the `KILL_NESTED_CONTAINER` call on the Agent API. This is > triggered when the executor receives a `KILL`/`SHUTDOWN` > event. Currently, only SIGKILL is supported. Also, the specifying > custom kill policies is not yet supported. > > > Diffs > ----- > > src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c > > Diff: https://reviews.apache.org/r/52148/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
