----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52174/#review150320 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp (line 5922) <https://reviews.apache.org/r/52174/#comment218258> s/EITHER/either/ ? src/tests/partition_tests.cpp (line 947) <https://reviews.apache.org/r/52174/#comment218259> s/Shutdown/Disconnect/ ? - Vinod Kone On Sept. 23, 2016, 11:17 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52174/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 11:17 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6226 > https://issues.apache.org/jira/browse/MESOS-6226 > > > Repository: mesos > > > Description > ------- > > We previously assumed that when marking a task unreachable, we would > have access to the `FrameworkInfo` for that task's framework. However, > that is not the case if the master has failed over and the framework has > not yet reregistered with the new master. > > > Diffs > ----- > > src/master/master.cpp 66a672f6d16233e96b29e330a9e6c474546fa851 > src/tests/partition_tests.cpp 7c38f0efa414447e6292b2d6b334fb9879c92eb5 > > Diff: https://reviews.apache.org/r/52174/diff/ > > > Testing > ------- > > `make check` on OSX. > > > Thanks, > > Neil Conway > >
