> On Sept. 20, 2016, 2:38 a.m., Jie Yu wrote: > > src/Makefile.am, line 834 > > <https://reviews.apache.org/r/50271/diff/11/?file=1502609#file1502609line834> > > > > This should belong linux files below? > > Benjamin Bannier wrote: > This isolator has no hard dependency on Linux so we can build it on all > platforms. I think it would be great to have as much code as possible not > behind `ifdef`s. What do you think?
I don't see any way to impl that on mac. All the capability constants we defined in header is linux specific. I still suggest we make it linux specific. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review149587 ----------------------------------------------------------- On Sept. 20, 2016, 11:40 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50271/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 11:40 a.m.) > > > Review request for mesos, Jay Guo and Jie Yu. > > > Bugs: MESOS-5275 > https://issues.apache.org/jira/browse/MESOS-5275 > > > Repository: mesos > > > Description > ------- > > This isolator evaluates agent allowed capabilities and passes net > capabilities on to `mesos-containerizer` which enforces the > capabilities. > > Capability information is passed via a new field in > `ContainerLaunchInfo`. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 20db010ea158a813034b411111ce9cddac7d8317 > src/CMakeLists.txt 42c52b60cc850901f2eff1545cf7900f4a65ca81 > src/Makefile.am 478fb5ae01dbdf1a735680edf7c5f30867726e07 > src/slave/containerizer/mesos/containerizer.cpp > e54169ba00f6e0cdd7043075b4cdd12d714c99e3 > src/slave/containerizer/mesos/isolators/linux/capabilities.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp PRE-CREATION > src/slave/containerizer/mesos/launch.hpp > 859990cb85e9e8c06400397256cfc512f0811800 > src/slave/containerizer/mesos/launch.cpp > fc51e04ec1572679e6a48ff4f0fa31ef2dfd6ec3 > src/slave/flags.hpp 3952d04f6a00ac1dca1adf2bea7cc6e415620ce5 > src/tests/containerizer/isolator_tests.cpp > 93ce75180520d382f63ce7323be844fe43c6594e > > Diff: https://reviews.apache.org/r/50271/diff/ > > > Testing > ------- > > `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o > optimizations) > > > Thanks, > > Benjamin Bannier > >
