----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52059/#review149612 -----------------------------------------------------------
I just had a chance to look at the fixture. src/tests/container_logger_tests.cpp (lines 784 - 785) <https://reviews.apache.org/r/52059/#comment217271> Ideally you would prevent such leakage from the test fixture. Any reason you cannot use an existing unpriviledged account like e.g., `nobody`? src/tests/container_logger_tests.cpp (line 832) <https://reviews.apache.org/r/52059/#comment217270> Note: since you use `CHECK_SOME` here no fixture teardown will be run (not even its dtr). - Benjamin Bannier On Sept. 19, 2016, 9:38 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52059/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 9:38 p.m.) > > > Review request for mesos, Artem Harutyunyan and Sivaram Kannan. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > This test creates a non-privileged user and but runs the agent > as root. Logrotate has several branches of logic that are only > exercised as root. In this case, we expect logrotate to work > if the agent and module are root, but the task is non-root. > > > Diffs > ----- > > src/tests/container_logger_tests.cpp > 1b121a2fcce2d874aeefc4257b9d4e594866e78d > > Diff: https://reviews.apache.org/r/52059/diff/ > > > Testing > ------- > > make check > > The new test currently fails (as expected). > > > Thanks, > > Joseph Wu > >
