----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52013/#review149403 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/paths.hpp (line 59) <https://reviews.apache.org/r/52013/#comment217011> s/ForContainer// ContainerId indicates that it's for a container. src/slave/containerizer/mesos/paths.hpp (line 60) <https://reviews.apache.org/r/52013/#comment217010> instead of passing in flags, I'd suggest we passing in rootDir (similar to what we did in slave/paths.hpp). src/slave/containerizer/mesos/paths.cpp (line 50) <https://reviews.apache.org/r/52013/#comment217012> Let's pull "containers" here as a const in cpp file. src/slave/containerizer/mesos/paths.cpp (line 61) <https://reviews.apache.org/r/52013/#comment217013> Ditto on "status" - Jie Yu On Sept. 18, 2016, 6:32 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52013/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2016, 6:32 p.m.) > > > Review request for mesos, Benjamin Hindman, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-6204 > https://issues.apache.org/jira/browse/MESOS-6204 > > > Repository: mesos > > > Description > ------- > > Added helper functions for container runtime paths. > > > Diffs > ----- > > src/CMakeLists.txt 42c52b60cc850901f2eff1545cf7900f4a65ca81 > src/Makefile.am 6fb095f58cf943c5597175df695046cfa21b68fd > src/slave/containerizer/mesos/paths.hpp PRE-CREATION > src/slave/containerizer/mesos/paths.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52013/diff/ > > > Testing > ------- > > This patch should be commited with `--author="Gilbert Song > <[email protected]>"` > > > Thanks, > > Kevin Klues > >
