> On Sept. 18, 2016, 2:01 p.m., haosdent huang wrote: > > src/slave/http.cpp, lines 985-997 > > <https://reviews.apache.org/r/51868/diff/1/?file=1498237#file1498237line985> > > > > Should we follow what we do in `master/http.cpp`? > > > > ``` > > hashmap<string, Resources> reserved = > > slave->totalResources.reservations(); > > > > writer->field( > > "reserved_resources_full", > > [&reserved](JSON::ObjectWriter* writer) { > > foreachpair (const string& role, > > const Resources& resources, > > reserved) { > > writer->field(role, [&resources](JSON::ArrayWriter* > > writer) { > > foreach (const Resource& resource, resources) { > > writer->element(JSON::Protobuf(resource)); > > } > > }); > > } > > }); > > ```
Saw you have updated to `totalResources.reservations()` in https://reviews.apache.org/r/51869/ :) - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51868/#review149367 ----------------------------------------------------------- On Sept. 14, 2016, 6:21 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51868/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 6:21 p.m.) > > > Review request for mesos, Anindya Sinha and Neil Conway. > > > Bugs: MESOS-4668 > https://issues.apache.org/jira/browse/MESOS-4668 > > > Repository: mesos > > > Description > ------- > > Expose full reservation info in the agent's http endpoint. > > > Diffs > ----- > > src/slave/http.cpp 67463105d7fa38b2158a64f6994e3dd353a9fcc7 > > Diff: https://reviews.apache.org/r/51868/diff/ > > > Testing > ------- > > make check. A new test is added in https://reviews.apache.org/r/51870/. > > > Thanks, > > Jiang Yan Xu > >
