----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51866/#review148997 -----------------------------------------------------------
src/slave/slave.cpp (line 5064) <https://reviews.apache.org/r/51866/#comment216525> Why is it verified against the old flag? `Slave::recover()` is the last step in `Slave::initialize()` by which time `info.resources()` reflects the `--resources` flag in this instance of mesos-slave process. So we are verifying with the new flag. - Anindya Sinha On Sept. 14, 2016, 6:21 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51866/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 6:21 p.m.) > > > Review request for mesos, Anindya Sinha and Neil Conway. > > > Bugs: MESOS-4668 > https://issues.apache.org/jira/browse/MESOS-4668 > > > Repository: mesos > > > Description > ------- > > In handling CheckpointResourcesMessage, the agent should first make > sure the checkpointed resources are compatible before it syncs local > disk state. > > > Diffs > ----- > > src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c > > Diff: https://reviews.apache.org/r/51866/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
