----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51674/#review148032 -----------------------------------------------------------
This patch does not look correct. I think we need a top level destroy which is nesting aware. We might want to rename the existing destory to `_destroy` which is not nesting aware. THe top level destroy will recursively call destroy for its children and calling `wait` for them to finish before calling `_destory` for itself. src/slave/containerizer/mesos/containerizer.cpp (line 1634) <https://reviews.apache.org/r/51674/#comment215404> why this change there? The original sentense sounds fine to me src/slave/containerizer/mesos/containerizer.cpp (line 1645) <https://reviews.apache.org/r/51674/#comment215408> Again, why this change? src/slave/containerizer/mesos/containerizer.cpp (lines 1652 - 1657) <https://reviews.apache.org/r/51674/#comment215409> This is not correct. 'destroy' simply initiate the destroy. You need to call 'wait' to wait for it to finish. - Jie Yu On Sept. 6, 2016, 9:53 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51674/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 9:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Supported mesos containerizer destroy to be nested aware. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 89b7e8db38916d69d9b2d4fe305d4397b0859a10 > > Diff: https://reviews.apache.org/r/51674/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
